Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ci): replace third-party shellcheck action #209

Merged
merged 3 commits into from
May 7, 2020

Conversation

jdville03
Copy link
Member

shellcheck is preinstalled on current version of GHA virtual env, so just run it directly instead of using an action at all.

The environment version in this sub-job is pinned since it now relies on something being present in the environment's preinstalled software, as a safety hedge just in case this is removed as preinstalled software when latest of ubuntu for GHA changes in ~2 years.

(conforming change with openlawteam/openlaw-app#3140)

@jdville03 jdville03 requested review from mroth and fforbeck May 7, 2020 22:41
Copy link
Contributor

@mroth mroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdville03 jdville03 merged commit 1616591 into master May 7, 2020
@jdville03 jdville03 deleted the shellcheck-action branch May 7, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants